Skip to content

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Mar 24, 2025

Not clean, has two follow up fixes in this PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issues

  • JDK-8344049: Shenandoah: Eliminate init-update-refs safepoint (Task - P4)
  • JDK-8344050: Shenandoah: Retire GC LABs concurrently (Sub-task - P4)
  • JDK-8344055: Shenandoah: Make all threads use local gc state (Sub-task - P4)
  • JDK-8348268: Test gc/shenandoah/TestResizeTLAB.java#compact: fatal error: Before Updating References: Thread C2 CompilerThread1: expected gc-state 9, actual 21 (Bug - P3)
  • JDK-8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/161/head:pull/161
$ git checkout pull/161

Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/shenandoah-jdk21u.git pull/161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 161

View PR using the GUI difftool:
$ git pr show -t 161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah-jdk21u/pull/161.diff

Using Webrev

Link to Webrev Comment

William Kemper and others added 4 commits March 24, 2025 15:50
… <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)

Reviewed-by: shade
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344049: Shenandoah: Eliminate init-update-refs safepoint
8344050: Shenandoah: Retire GC LABs concurrently
8344055: Shenandoah: Make all threads use local gc state
8348268: Test gc/shenandoah/TestResizeTLAB.java#compact: fatal error: Before Updating References: Thread C2 CompilerThread1: expected gc-state 9, actual 21
8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)

Reviewed-by: kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 14ba6af: Merge
  • 4d3a3c0: 8352097: (tz) zone.tab update missed in 2025a backport

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 764d70b7df18e288582e616c62b0d7078f1ff3aa 8344049: Shenandoah: Eliminate init-update-refs safepoint Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 24, 2025
@earthling-amzn
Copy link
Contributor Author

/issue add JDK-8348268, JDK-8348092

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@earthling-amzn
Adding additional issue to issue list: 8348268: Test gc/shenandoah/TestResizeTLAB.java#compact: fatal error: Before Updating References: Thread C2 CompilerThread1: expected gc-state 9, actual 21.

Adding additional issue to issue list: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710).

@mlbridge
Copy link

mlbridge bot commented Mar 24, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 27, 2025
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

Going to push as commit b5cf88c.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 14ba6af: Merge
  • 4d3a3c0: 8352097: (tz) zone.tab update missed in 2025a backport

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2025
@openjdk openjdk bot closed this Mar 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@earthling-amzn Pushed as commit b5cf88c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants