-
Notifications
You must be signed in to change notification settings - Fork 11
8364936: Shenandoah: Switch nmethod entry barriers to conc_instruction_and_data_patch #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8364936: Shenandoah: Switch nmethod entry barriers to conc_instruction_and_data_patch #218
Conversation
|
👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into |
|
@JohnTortugo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
9da2a76 to
0020610
Compare
|
@JohnTortugo Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
|
@JohnTortugo |
|
/sponsor |
|
Going to push as commit d9eaa69.
Your commit was automatically rebased without conflicts. |
|
@earthling-amzn @JohnTortugo Pushed as commit d9eaa69. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 81a1e8e1 from the openjdk/jdk repository.
The commit being backported was authored by Cesar Soares Lucas on 8 Sep 2025 and was reviewed by Fei Yang, Dingli Zhang, Kelvin Nilsen and William Kemper.
I had to manually resolve a merge conflict in
TestHotSpotVMConfig.javabecause the original patch modified a region of the file that is not present in this repository version of the same file.Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/218/head:pull/218$ git checkout pull/218Update a local copy of the PR:
$ git checkout pull/218$ git pull https://git.openjdk.org/shenandoah-jdk21u.git pull/218/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 218View PR using the GUI difftool:
$ git pr show -t 218Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah-jdk21u/pull/218.diff
Using Webrev
Link to Webrev Comment