Skip to content

8368152: Shenandoah: Incorrect behavior at end of degenerated cycle#222

Closed
earthling-amzn wants to merge 2 commits intoopenjdk:masterfrom
earthling-amzn:fix-degen-brownout-21u
Closed

8368152: Shenandoah: Incorrect behavior at end of degenerated cycle#222
earthling-amzn wants to merge 2 commits intoopenjdk:masterfrom
earthling-amzn:fix-degen-brownout-21u

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Sep 24, 2025

Not clean, but trivial conflict resolution.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8368152: Shenandoah: Incorrect behavior at end of degenerated cycle (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/222/head:pull/222
$ git checkout pull/222

Update a local copy of the PR:
$ git checkout pull/222
$ git pull https://git.openjdk.org/shenandoah-jdk21u.git pull/222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 222

View PR using the GUI difftool:
$ git pr show -t 222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah-jdk21u/pull/222.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368152: Shenandoah: Incorrect behavior at end of degenerated cycle

Reviewed-by: kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f36c33c86df0400d2155bfadd9a6b5ea56743133 8368152: Shenandoah: Incorrect behavior at end of degenerated cycle Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 24, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2025

Webrevs

Copy link
Contributor

@kdnilsen kdnilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your urgency on this.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2025
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2025

Going to push as commit 7fccea8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2025
@openjdk openjdk bot closed this Sep 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@earthling-amzn Pushed as commit 7fccea8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants