Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253424: Add support for running pre-submit testing using GitHub Actions #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Apr 17, 2022

Hi all,

This pull request contains a backport of commit 10029f78 from the openjdk/jdk8u-dev repository, which enables GitHub Actions for the Shenandoah 8u fork.

The commit being backported was authored by Andrew John Hughes on 6 Apr 2022 and was reviewed by Severin Gehwolf.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issues

  • JDK-8253424: Add support for running pre-submit testing using GitHub Actions
  • JDK-8253865: Pre-submit testing using GitHub Actions does not detect failures reliably
  • JDK-8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command
  • JDK-8254173: Add Zero, Minimal hotspot targets to submit workflow
  • JDK-8254175: Build no-pch configuration in debug mode for submit checks
  • JDK-8254282: Add Linux x86_32 builds to submit workflow
  • JDK-8255373: Submit workflow artifact name is always "test-results_.zip"
  • JDK-8255895: Submit workflow artifacts miss hs_errs/replays due to ZIP include mismatch
  • JDK-8256127: Add cross-compiled foreign architectures builds to submit workflow
  • JDK-8256277: Github Action build on macOS should define OS and Xcode versions
  • JDK-8256354: Github Action build on Windows should define OS and MSVC versions
  • JDK-8256414: add optimized build to submit workflow
  • JDK-8256393: Github Actions build on Linux should define OS and GCC versions
  • JDK-8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing
  • JDK-8257056: Submit workflow should apt-get update to avoid package installation errors
  • JDK-8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
  • JDK-8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
  • JDK-8263667: Avoid running GitHub actions on branches named pr/*
  • JDK-8255305: Add Linux x86_32 tier1 to submit workflow
  • JDK-8255352: Archive important test outputs in submit workflow
  • JDK-8282225: GHA: Allow one concurrent run per PR only
  • JDK-8241768: git needs .gitattributes
  • JDK-8284772: 8u GHA: Use GCC Major Version Dependencies Only

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/shenandoah-jdk8u pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/shenandoah-jdk8u pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/shenandoah-jdk8u/pull/3.diff

@gnu-andrew gnu-andrew marked this pull request as draft Apr 17, 2022
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 17, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 10029f784ef7be458a7b6ff3cc21649ff0abb6f3 8253424: Add support for running pre-submit testing using GitHub Actions Apr 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added the backport label Apr 25, 2022
@erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 25, 2022

The .jcheck/conf file is still broken in this repo. Please run git jcheck in locally in the repo to see the exception.

@gnu-andrew
Copy link
Member Author

@gnu-andrew gnu-andrew commented May 1, 2022

The .jcheck/conf file is still broken in this repo. Please run git jcheck in locally in the repo to see the exception.

I have. I've fixed it locally and in this PR, but jcheck only picks it up when it's applied to the master branch. I guess I'll have to do another direct push with it. I'm waiting on ops to add shenandoah8u332 to the list of JBS versions.

@gnu-andrew
Copy link
Member Author

@gnu-andrew gnu-andrew commented May 4, 2022

/issue 8241768
/issue 8284772

@gnu-andrew
Copy link
Member Author

@gnu-andrew gnu-andrew commented May 4, 2022

git jcheck is now passing locally. Will it re-run on this PR?

@gnu-andrew gnu-andrew marked this pull request as ready for review May 4, 2022
@openjdk openjdk bot added the rfr label May 4, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2022

@gnu-andrew
Adding additional issue to issue list: 8241768: git needs .gitattributes.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 4, 2022

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2022

@gnu-andrew
Adding additional issue to issue list: 8284772: 8u GHA: Use GCC Major Version Dependencies Only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr
3 participants