8344151: GenShen: Improve comments, clean up unnecessary changes

Reviewed-by: shade

Author: William Kemper

src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp

@@ -115,23 +115,17 @@ class ShenandoahHeuristics : public CHeapObj<mtGC> {
     }
 
     inline ShenandoahHeapRegion* get_region() const {
-#ifdef ASSERT
-      assert(_union_tag != is_uninitialized, "Cannot fetch region from uninialized RegionData");
-#endif
+      assert(_union_tag != is_uninitialized, "Cannot fetch region from uninitialized RegionData");
       return _region;
     }
 
     inline size_t get_garbage() const {
-#ifdef ASSERT
       assert(_union_tag == is_garbage, "Invalid union fetch");
-#endif
       return _region_union._garbage;
     }
 
     inline size_t get_livedata() const {
-#ifdef ASSERT
       assert(_union_tag == is_live_data, "Invalid union fetch");
-#endif
       return _region_union._live_data;
     }
   };

src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp

@@ -235,7 +235,7 @@ class ShenandoahAsserts {
 #define shenandoah_assert_control_or_vm_thread()
 #define shenandoah_assert_control_or_vm_thread_at_safepoint()
 #define shenandoah_assert_generational()
-#define shenandoah_assert_generations_reconciled()                                                             \
+#define shenandoah_assert_generations_reconciled()
 
 #endif
 

src/hotspot/share/gc/shenandoah/shenandoahVMOperations.hpp

@@ -38,7 +38,7 @@ class ShenandoahFullGC;
 //   - VM_ShenandoahFinalMarkStartEvac: finish up concurrent marking, and start evacuation
 //   - VM_ShenandoahInitUpdateRefs: initiate update references
 //   - VM_ShenandoahFinalUpdateRefs: finish up update references
-//   - VM_ShenandoahFinalRoots
+//   - VM_ShenandoahFinalRoots: finish up roots on a non-evacuating cycle
 //   - VM_ShenandoahReferenceOperation:
 //       - VM_ShenandoahFullGC: do full GC
 //       - VM_ShenandoahDegeneratedGC: do STW degenerated GC

test/hotspot/jtreg/ProblemList.txt

@@ -95,6 +95,7 @@ gc/TestAlwaysPreTouchBehavior.java#G1 8334513 generic-all
 gc/TestAlwaysPreTouchBehavior.java#Z 8334513 generic-all
 gc/TestAlwaysPreTouchBehavior.java#Epsilon 8334513 generic-all
 gc/stress/gclocker/TestExcessGCLockerCollections.java 8229120 generic-all
+
 #############################################################################
 
 # :hotspot_runtime