8309693: Synchronize openjdk/shenandoah:master with changes made for PR #285
Conversation
…bles Though changes to the volatile variables are individually protected by Atomic load and store operations, these asserts were not assuring atomic access to multiple volatile variables, each of which could be modified independently of the others. The asserts were therefore not trustworthy, as has been confirmed by more extensive testing.
When generational Shenandoah is used, there may be an additional alignment related heap size adjustment that the test should be cognizant of. Such alignment might also happen in the non-generational case, but in this case the specific size used in the test was affected on machines with larger than usual os page size settings. The alignment related adjustment would have affected all generational collectors (except perhaps Gen Z). In the future, we might try and relax this alignment constraint.alignment.
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
Webrevs
|
| ignore=duke | ||
|
|
||
| [checks "committer"] | ||
| role=committer | ||
|
|
||
| [checks "issues"] | ||
| pattern=^([124-8][0-9]{6}): (\S.*)$ | ||
|
|
||
| [checks "problemlists"] |
There was a problem hiding this comment.
I'd remove any changes to jcheck by adding it to your gitignore or something.
There was a problem hiding this comment.
Similarly, is the intention to remove the genshen-docs folder & its contents from the project repo entirely, or just let it lie there quietly. Not sure if there might be value in keeping it or if it has outlived its usefulness.
In particular, the docs seem to include a design summary and a glossary of terms that might still have value (if suitably updated)?
There was a problem hiding this comment.
OTOH may be the intention is to change the jcheck for project repo to align it with upstream in which case ignore my first comment in thread.
There was a problem hiding this comment.
I just didn't want to have to "redo" the undo of these changes for the next PR. I think if those design docs are still useful, we ought to incorporate them in the JEP or as a comment in shenandoahGeneration.hpp?
We originally disabled the jcheck rule that required PR's to have a JBS ticket because we weren't really using JBS at the time, but I think the intention going forward is that we are using JBS, so we should have the rule again.
|
/integrate |
|
@earthling-amzn This pull request has not yet been marked as ready for integration. |
earthling-amzn
changed the title
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 5795bc6. |
openjdk
bot
removed
ready
|
@earthling-amzn Pushed as commit 5795bc6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR incorporates changes made in response to openjdk/jdk#14185
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/285/head:pull/285$ git checkout pull/285Update a local copy of the PR:
$ git checkout pull/285$ git pull https://git.openjdk.org/shenandoah.git pull/285/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 285View PR using the GUI difftool:
$ git pr show -t 285Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/285.diff
Webrev
Link to Webrev Comment