8310062: [Shenandoah] Incomplete SATB buffers may not be processed during degenerated young collection

[earthling-amzn]

When Shenandoah's young generation exhausts available memory, it transitions to a "degenerated" cycle. If old marking is in progress, SATB queues need to be drained before evacuation to avoid invalidating any pointers in the queues. In the case when old marking is active and the concurrent collection failed during root scan, the SATB queues might not be drained - this is an error.

The change here moves handling of the old pointers in the SATB queues to the case when degeneration occurs during the root scan. We could rely on SATB processing in the degenerated mark case, but we would still need the explicit methods for handling old pointers during the concurrent cycles.

The verifier has also been modified to check that all SATB buffers are empty after marking is complete. This is only valid after marking is completed on the safepoint. If concurrent marking for old is in progress, the SATB queues are not expected to be empty during other phases of a concurrent young collection.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8310062: [Shenandoah] Incomplete SATB buffers may not be processed during degenerated young collection (Bug - P4)

Reviewers

• Y. Srinivas Ramakrishna (@ysramakrishna - Committer)
• Kelvin Nilsen (@kdnilsen - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/287/head:pull/287
$ git checkout pull/287

Update a local copy of the PR:
$ git checkout pull/287
$ git pull https://git.openjdk.org/shenandoah.git pull/287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 287

View PR using the GUI difftool:
$ git pr show -t 287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/287.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (c3325bda)
• 00: Full (f4b635fa)

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310062: [Shenandoah] Incomplete SATB buffers may not be processed during degenerated young collection

Reviewed-by: ysr, kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn This pull request has not yet been marked as ready for integration.

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version f4b635f) is now ready to be sponsored by a Committer.

[earthling-amzn]

/integrate

[openjdk]

Going to push as commit 421f949.

[openjdk]

@earthling-amzn Pushed as commit 421f949.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.