-
Notifications
You must be signed in to change notification settings - Fork 38
8310075: Revert accidental change to jcheck configuration for shenandoah project #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8310075: Revert accidental change to jcheck configuration for shenandoah project #288
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
Webrevs
|
/integrate |
@earthling-amzn This pull request has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you might need a JDK project Reviewer to change that thing :)
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ysramakrishna, @shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@earthling-amzn |
/sponsor |
Going to push as commit c7cd380. |
@shipilev @earthling-amzn Pushed as commit c7cd380. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This bit of the configuration was clobbered with #285.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/288/head:pull/288
$ git checkout pull/288
Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.org/shenandoah.git pull/288/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 288
View PR using the GUI difftool:
$ git pr show -t 288
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/288.diff
Webrev
Link to Webrev Comment