Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310075: Revert accidental change to jcheck configuration for shenandoah project #288

Closed

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Jun 14, 2023

This bit of the configuration was clobbered with #285.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310075: Revert accidental change to jcheck configuration for shenandoah project (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/288/head:pull/288
$ git checkout pull/288

Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.org/shenandoah.git pull/288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 288

View PR using the GUI difftool:
$ git pr show -t 288

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/288.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2023

Webrevs

@earthling-amzn earthling-amzn changed the title 8310075 Revert accidental change to jcheck configuration for shenandoah project 8310075: Revert accidental change to jcheck configuration for shenandoah project Jun 14, 2023
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@earthling-amzn This pull request has not yet been marked as ready for integration.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you might need a JDK project Reviewer to change that thing :)

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310075: Revert accidental change to jcheck configuration for shenandoah project

Reviewed-by: ysr, kdnilsen, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ysramakrishna, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2023
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@earthling-amzn
Your change (at version d497b1b) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

Going to push as commit c7cd380.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 15, 2023
@openjdk openjdk bot closed this Jun 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@shipilev @earthling-amzn Pushed as commit c7cd380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants