Skip to content

8316137: GenShen: missing ShenandoahCardBarrier filter #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ysramakrishna
Copy link
Member

@ysramakrishna ysramakrishna commented Sep 12, 2023

A few instances of (inline) calls to the card-barrier code from the VM missed the idiomatic changes in the parent ticket https://bugs.openjdk.org/browse/JDK-8315247. This PR takes care of the cases that I had previously missed where we were doing a generational mode check on the heap.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8316137: GenShen: missing ShenandoahCardBarrier filter (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/322/head:pull/322
$ git checkout pull/322

Update a local copy of the PR:
$ git checkout pull/322
$ git pull https://git.openjdk.org/shenandoah.git pull/322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 322

View PR using the GUI difftool:
$ git pr show -t 322

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/322.diff

Webrev

Link to Webrev Comment

@ysramakrishna
Copy link
Member Author

ysramakrishna commented Sep 12, 2023

/issue JDK-8316137

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back ysr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8316137: GenShen: missing ShenandoahCardBarrier filter 8316137: GenShen: missing ShenandoahCardBarrier filter Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@ysramakrishna This issue is referenced in the PR title - it will now be updated.

@ysramakrishna ysramakrishna marked this pull request as ready for review September 12, 2023 19:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@ysramakrishna This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316137: GenShen: missing ShenandoahCardBarrier filter

Reviewed-by: wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2023
@ysramakrishna
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit ba88eb1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@ysramakrishna Pushed as commit ba88eb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Contributor

@kdnilsen kdnilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ysramakrishna ysramakrishna deleted the card_barrier branch November 30, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants