Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319198: GenShen: Old at end of Full GC must include newly promoted objects #350

Closed

Conversation

kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Nov 1, 2023

At end of Full GC, remember live bytes after last old-gen mark after promotions are completed rather than immediately after old marking is completed. This is a more accurate representation of old live. This reduces the likelihood that we will need to immediately trigger another old-gen GC following the Full GC.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8319198: GenShen: Old at end of Full GC must include newly promoted objects (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.org/shenandoah.git pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/350.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8319198: GenShen: Old at end of Full GC must include newly promoted objects 8319198: GenShen: Old at end of Full GC must include newly promoted objects Nov 1, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319198: GenShen: Old at end of Full GC must include newly promoted objects

Reviewed-by: wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2023
@kdnilsen
Copy link
Contributor Author

kdnilsen commented Nov 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit e4a8a43.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kdnilsen Pushed as commit e4a8a43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants