8334681: GenShen: Do not use gtest skip test feature #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of gtest provide a means to skip tests [1]. Unfortunately, the test result parsing in the build counts them as errors and fails the build.
[1] https://google.github.io/googletest/advanced.html#skipping-test-execution
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/452/head:pull/452$ git checkout pull/452Update a local copy of the PR:
$ git checkout pull/452$ git pull https://git.openjdk.org/shenandoah.git pull/452/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 452View PR using the GUI difftool:
$ git pr show -t 452Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/452.diff
Webrev
Link to Webrev Comment