8338479: GenShen: Detemplatize ShenandoahScanRemembered

[ysramakrishna]

De-templatize ShenandoahScanRemembered and ShenandoahCardCluster, based on Roman's review feedback at https://github.com/openjdk/jdk/pull/20395/files/46638cdef26fd25c290e6f63035ff5d2f1dc3bdb#r1718773835.

/issue JDK-8338479

Testing:

• GHA
• jtreg:tier1
• codepipeline
• SPECjbb

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8338479: GenShen: Detemplatize ShenandoahScanRemembered (Task - P4)

Reviewers

• Kelvin Nilsen (@kdnilsen - Committer) ⚠️ Review applies to b97b7a14
• William Kemper (@earthling-amzn - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/472/head:pull/472
$ git checkout pull/472

Update a local copy of the PR:
$ git checkout pull/472
$ git pull https://git.openjdk.org/shenandoah.git pull/472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 472

View PR using the GUI difftool:
$ git pr show -t 472

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/472.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ysramakrishna This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338479: GenShen: Detemplatize ShenandoahScanRemembered

Reviewed-by: kdnilsen, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@ysramakrishna This issue is referenced in the PR title - it will now be updated.

[mlbridge]

Webrevs

• 04: Full - Incremental (ed6a0a96)
• 03: Full - Incremental (0c19ca5f)
• 02: Full - Incremental (4ebd404a)
• 01: Full - Incremental (8433b9cd)
• 00: Full (b97b7a14)

[kdnilsen]

Thanks for quick turnaround on this. I assume we'll complete all tests before integrating.

[ysramakrishna]

Running specjbb perf numbers and codepipeline again after syncing with latest changes in master. Will push later today once all is clear and no perf differences (don't expect any). Left the inline specifier intact on those methods as requested by William.

Thanks for your reviews!

[ysramakrishna]

Thanks for your reviews!

/integrate

[openjdk]

Going to push as commit 78277f9.

[openjdk]

@ysramakrishna Pushed as commit 78277f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.