8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior #497
Conversation
|
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
|
@kdnilsen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
| @@ -1424,10 +1425,14 @@ void ShenandoahFreeSet::find_regions_with_alloc_capacity(size_t &young_cset_regi | |||
| old_collector_leftmost, old_collector_rightmost, old_collector_leftmost_empty, old_collector_rightmost_empty, | |||
| old_collector_regions, old_collector_used); | |||
|
|
|||
| _partitions.establish_mutator_intervals(mutator_leftmost, mutator_rightmost, mutator_leftmost_empty, mutator_rightmost_empty, | |||
| idx_t rightmost_idx = (mutator_leftmost == max_regions)? -1: (idx_t) mutator_rightmost; | |||
There was a problem hiding this comment.
Does this also affect upstream? Should we have a non-genshen patch too?
There was a problem hiding this comment.
We should do this upstream as well. (or it will go upstream when we merge, but that might take a while). I wanted to test and integrate "quickly" into our internal test distribution.
There was a problem hiding this comment.
kdnilsen
changed the title
|
/integrate |
openjdk
bot
removed
ready
This fixes some bugs found in recent code review and playback of an assertion failure.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/497/head:pull/497$ git checkout pull/497Update a local copy of the PR:
$ git checkout pull/497$ git pull https://git.openjdk.org/shenandoah.git pull/497/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 497View PR using the GUI difftool:
$ git pr show -t 497Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/497.diff
Webrev
Link to Webrev Comment