-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341485: GenShen: Make evac tracker a non-product feature and confine it to generational mode #506
8341485: GenShen: Make evac tracker a non-product feature and confine it to generational mode #506
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
(Left a comment/question about another change that kinda snuck in; but it's probably OK to sneak it in here rather than the extra overhead of a separate PR, if you intended it...)
/integrate |
Going to push as commit bd7d34d. |
@earthling-amzn Pushed as commit bd7d34d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
During the course of development of the generational mode, we added a feature to keep track of which threads were evacuating objects and how many evacuations lost the race. The instrumentation added unwarranted overhead. This change makes this instrumentation a non-product feature for the generational mode and removes it entirely from the non-generational modes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/506/head:pull/506
$ git checkout pull/506
Update a local copy of the PR:
$ git checkout pull/506
$ git pull https://git.openjdk.org/shenandoah.git pull/506/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 506
View PR using the GUI difftool:
$ git pr show -t 506
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/506.diff
Webrev
Link to Webrev Comment