-
Notifications
You must be signed in to change notification settings - Fork 37
8344151: GenShen: Improve comments, clean up unnecessary changes #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@earthling-amzn This pull request has not yet been marked as ready for integration. |
|
/integrate |
|
@earthling-amzn Pushed as commit efb3a05. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Address a few style nits from: openjdk/jdk#21273
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/536/head:pull/536$ git checkout pull/536Update a local copy of the PR:
$ git checkout pull/536$ git pull https://git.openjdk.org/shenandoah.git pull/536/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 536View PR using the GUI difftool:
$ git pr show -t 536Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/536.diff
Using Webrev
Link to Webrev Comment