Skip to content

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Nov 25, 2024

Make the difference in behavior for generational and other modes more clear.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8344985: GenShen: Refactor arraycopy barrier for generational mode (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/553/head:pull/553
$ git checkout pull/553

Update a local copy of the PR:
$ git checkout pull/553
$ git pull https://git.openjdk.org/shenandoah.git pull/553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 553

View PR using the GUI difftool:
$ git pr show -t 553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/553.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344985: GenShen: Refactor arraycopy barrier for generational mode

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 413 new commits pushed to the master branch:

  • e22e8d5: Merge
  • 4fbf272: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
  • 1343911: 8340334: Update jcmd VM.events max parameter to be INT
  • 400eb9b: 8344524: Remove SecurityManager related code from jdk.jlink module
  • a599c30: 8344471: Remove SecurityManager related code from java.compiler module
  • b9bf447: 8344057: Remove doPrivileged calls from unix platform sources in the java.desktop module
  • da2d7a0: 8344595: State transitions in internal VirtualThread comment needs to be updated
  • 22a39dc: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module
  • 27fda0e: 8344578: Clean up left over java.security and sun.security imports in Swing classes
  • 080f1cc: 8289771: jpackage: ResourceEditor error when path is overly long on Windows
  • ... and 403 more: https://git.openjdk.org/shenandoah/compare/2b505eebe5006673f99c58922434f43aab4b7b77...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

Going to push as commit 34d334d.
Since your change was applied there have been 413 commits pushed to the master branch:

  • e22e8d5: Merge
  • 4fbf272: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
  • 1343911: 8340334: Update jcmd VM.events max parameter to be INT
  • 400eb9b: 8344524: Remove SecurityManager related code from jdk.jlink module
  • a599c30: 8344471: Remove SecurityManager related code from java.compiler module
  • b9bf447: 8344057: Remove doPrivileged calls from unix platform sources in the java.desktop module
  • da2d7a0: 8344595: State transitions in internal VirtualThread comment needs to be updated
  • 22a39dc: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module
  • 27fda0e: 8344578: Clean up left over java.security and sun.security imports in Swing classes
  • 080f1cc: 8289771: jpackage: ResourceEditor error when path is overly long on Windows
  • ... and 403 more: https://git.openjdk.org/shenandoah/compare/2b505eebe5006673f99c58922434f43aab4b7b77...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 25, 2024
@openjdk openjdk bot closed this Nov 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2024
@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@earthling-amzn Pushed as commit 34d334d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants