Skip to content
Permalink
Browse files

Add "Required" title to jcheck-check only if it fails

Reviewed-by: rwestberg
  • Loading branch information
Erik Helin
Erik Helin committed Nov 6, 2019
1 parent 0d73a1f commit 43f8ff2bcef019e8314e9a3862f2f0357a63908c
Showing with 1 addition and 1 deletion.
  1. +1 −1 bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
@@ -171,6 +171,7 @@ private void updateCheckBuilder(CheckBuilder checkBuilder, PullRequestCheckIssue
if (visitor.isReadyForReview() && additionalErrors.isEmpty()) {
checkBuilder.complete(true);
} else {
checkBuilder.title("Required");
var summary = Stream.concat(visitor.getMessages().stream(), additionalErrors.stream())
.sorted()
.map(m -> "- " + m)
@@ -448,7 +449,6 @@ private void updateMergeReadyComment(boolean isReady, String commitMessage, List

private void checkStatus() {
var checkBuilder = CheckBuilder.create("jcheck", pr.headHash());
checkBuilder.title("Required");
var censusDomain = censusInstance.configuration().census().domain();
Exception checkException = null;

0 comments on commit 43f8ff2

Please sign in to comment.
You can’t perform that action at this time.