Navigation Menu

Skip to content

Commit

Permalink
Add "Required" title to jcheck-check only if it fails
Browse files Browse the repository at this point in the history
Reviewed-by: rwestberg
  • Loading branch information
edvbld committed Nov 6, 2019
1 parent 0d73a1f commit 43f8ff2
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -171,6 +171,7 @@ private void updateCheckBuilder(CheckBuilder checkBuilder, PullRequestCheckIssue
if (visitor.isReadyForReview() && additionalErrors.isEmpty()) {
checkBuilder.complete(true);
} else {
checkBuilder.title("Required");
var summary = Stream.concat(visitor.getMessages().stream(), additionalErrors.stream())
.sorted()
.map(m -> "- " + m)
Expand Down Expand Up @@ -448,7 +449,6 @@ private void updateMergeReadyComment(boolean isReady, String commitMessage, List

private void checkStatus() {
var checkBuilder = CheckBuilder.create("jcheck", pr.headHash());
checkBuilder.title("Required");
var censusDomain = censusInstance.configuration().census().domain();
Exception checkException = null;

Expand Down

0 comments on commit 43f8ff2

Please sign in to comment.