Skip to content
Permalink
Browse files
Update messages when a reviewer isn't a project member
Reviewed-by: ehelin
  • Loading branch information
rwestberg committed Nov 12, 2019
1 parent e75c0b0 commit 592533cd597afcfb214d76ab102980d593febbab
Showing with 2 additions and 2 deletions.
  1. +2 −2 bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
@@ -319,7 +319,7 @@ private String projectRole(Contributor contributor) {
} else if (censusInstance.project().isAuthor(contributor.username(), version)) {
return "Author";
}
return "none";
return "no project role";
}

void addReview(Review review) {
@@ -356,7 +356,7 @@ void addReviewVerdict(Review review) {
}

var userName = contributor != null ? contributor.username() : review.reviewer().userName() + "@" + censusInstance.namespace().name();
var userRole = contributor != null ? projectRole(contributor) : "no project role";
var userRole = contributor != null ? projectRole(contributor) : "no OpenJDK username";
var replyBody = ArchiveMessages.reviewVerdictBody(review.body().orElse(""), review.verdict(), userName, userRole);

addReplyCommon(parent, review.reviewer(), subject, replyBody, id);

0 comments on commit 592533c

Please sign in to comment.