Skip to content
Permalink
Browse files
930: Skara bot adds confusing comment to PR when CSR is needed
Reviewed-by: rwestberg, kcr
  • Loading branch information
edvbld committed Apr 16, 2021
1 parent 132acee commit 64a8dc16ed6b72fac3ae21e627685a520f8de4d9
Showing with 4 additions and 4 deletions.
  1. +2 −2 bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java
  2. +2 −2 bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java
@@ -45,12 +45,12 @@ private static void csrReply(PrintWriter writer) {

private static void jbsReply(PullRequest pr, PrintWriter writer) {
writer.println("@" + pr.author().username() + " this pull request must refer to an issue in " +
"[JBS](https://bugs.openjdk.java.net) to be able to link it to a CSR request. To refer this pull request to " +
"[JBS](https://bugs.openjdk.java.net) to be able to link it to a [CSR](https://wiki.openjdk.java.net/display/csr/Main) request. To refer this pull request to " +
"an issue in JBS, please use the `/issue` command in a comment in this pull request.");
}

private static void linkReply(PullRequest pr, Issue issue, PrintWriter writer) {
writer.println("@" + pr.author().username() + " please create a CSR request and add link to it in " +
writer.println("@" + pr.author().username() + " please create a [CSR](https://wiki.openjdk.java.net/display/csr/Main) request for issue " +
"[" + issue.id() + "](" + issue.webUrl() + "). This pull request cannot be integrated until " +
"the CSR request is approved.");
}
@@ -174,7 +174,7 @@ void testMissingIssue(TestInfo testInfo) throws IOException {
"[compatibility and specification](https://wiki.openjdk.java.net/display/csr/Main) " +
"(CSR) request is needed for this pull request.");
assertLastCommentContains(pr, "this pull request must refer to an issue in [JBS]");
assertLastCommentContains(pr, "to be able to link it to a CSR request. To refer this pull request to an issue in JBS");
assertLastCommentContains(pr, "To refer this pull request to an issue in JBS");
assertTrue(pr.labelNames().contains("csr"));
}
}
@@ -296,7 +296,7 @@ void nonExistingJBSIssue(TestInfo testInfo) throws IOException {
"[compatibility and specification](https://wiki.openjdk.java.net/display/csr/Main) " +
"(CSR) request is needed for this pull request.");
assertLastCommentContains(pr, "this pull request must refer to an issue in [JBS]");
assertLastCommentContains(pr, "to be able to link it to a CSR request. To refer this pull request to an issue in JBS");
assertLastCommentContains(pr, "to be able to link it to a [CSR](https://wiki.openjdk.java.net/display/csr/Main) request. To refer this pull request to an issue in JBS");
assertTrue(pr.labelNames().contains("csr"));
}
}

1 comment on commit 64a8dc1

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 64a8dc1 Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.