From 72598254d79aaf23f10773d0d7f0ecb34815301b Mon Sep 17 00:00:00 2001 From: Robin Westberg Date: Tue, 20 Oct 2020 14:09:50 +0200 Subject: [PATCH] Avoid storing empty files --- .../java/org/openjdk/skara/storage/RepositoryStorage.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java b/storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java index adb55c513..042451f7e 100644 --- a/storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java +++ b/storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java @@ -25,6 +25,7 @@ import org.openjdk.skara.vcs.Repository; import java.io.*; +import java.nio.file.Files; import java.util.*; class RepositoryStorage implements Storage { @@ -74,8 +75,13 @@ public void put(Collection items) { } current = updated; try { - repository.add(repository.root().resolve(fileName)); + var filePath = repository.root().resolve(fileName); + repository.add(filePath); repository.commit(message, authorName, authorEmail); + + if (Files.size(filePath) == 0) { + throw new IllegalStateException("Storage file is empty: " + filePath); + } } catch (IOException e) { throw new UncheckedIOException(e); }