Skip to content
Permalink
Browse files
Proper detection of legacy integration comment
Reviewed-by: duke, ehelin
  • Loading branch information
rwestberg committed Apr 28, 2020
1 parent 1a0aaa6 commit b2ea62e5573753a8b04ba92769c7f8a83182cd76
@@ -71,7 +71,7 @@ private Optional<Hash> findIntegratedHash() {
}

private boolean hasLegacyIntegrationNotice(Hash hash) {
var legacyIntegrationPattern = Pattern.compile("Changeset: " + hash.abbreviate());
var legacyIntegrationPattern = Pattern.compile("Changeset\\\\?: " + hash.abbreviate());
return ignoredComments.stream()
.map(Comment::body)
.map(legacyIntegrationPattern::matcher)
@@ -402,8 +402,8 @@ void archiveLegacyIntegrated(TestInfo testInfo) throws IOException {

// Add legacy integration notice
ignoredPr.addComment(
"Changeset: " + editHash.abbreviate() + "\n" +
"Author: J. Duke <duke@openjdk.org>\n");
"Changeset\\: " + editHash.abbreviate() + "\n" +
"Author\\: J. Duke \\<duke at openjdk\\.org\\>\n");

// Run another archive pass
TestBotRunner.runPeriodicItems(mlBot);

0 comments on commit b2ea62e

Please sign in to comment.