Skip to content
Permalink
Browse files

25: The GitHub parsePullRequestUrl method is not pattern aware

Reviewed-by: ehelin
  • Loading branch information
Robin Westberg
Robin Westberg committed Jul 2, 2019
1 parent 61fc564 commit dc544565d1c924e273a419bbd5d9a190d7bffe9b
Showing with 3 additions and 4 deletions.
  1. +1 −1 build.gradle
  2. +2 −3 host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java
@@ -53,7 +53,7 @@ configure(subprojects.findAll() { it.name != 'bots' }) {

if (findProperty('credentials')) {
systemProperty "credentials", findProperty('credentials')
systemProperties(System.getProperties())
System.getProperties().findAll { it.key.toString().toLowerCase().contains('proxy') }.each { systemProperty it.key, it.value }
}

testLogging {
@@ -54,9 +54,8 @@
"Accept", "application/vnd.github.machine-man-preview+json",
"Accept", "application/vnd.github.antiope-preview+json"));
json = gitHubHost.getProjectInfo(repository);
var urlPattern = URIBuilder.base(gitHubHost.getURI())
.setPath("/" + repository + "/pull/").build();
pullRequestPattern = Pattern.compile(urlPattern.toString() + "(\\d+)");
var urlPattern = gitHubHost.getWebURI("/" + repository + "/pull/").toString();
pullRequestPattern = Pattern.compile(urlPattern + "(\\d+)");
}

@Override

0 comments on commit dc54456

Please sign in to comment.
You can’t perform that action at this time.