Permalink
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
744: The "Webrevs" link in the PR has confusing link to the changes f…
…or just one commit Reviewed-by: rwestberg
- Loading branch information
Showing
with
25 additions
and 1 deletion.
- +1 −1 bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
- +5 −0 bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java
- +2 −0 forge/src/main/java/org/openjdk/skara/forge/PullRequest.java
- +6 −0 forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
- +6 −0 forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
- +5 −0 test/src/main/java/org/openjdk/skara/test/TestPullRequest.java
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -314,4 +314,9 @@ public Diff diff() { | ||
public Optional<HostUser> closedBy() { | ||
return Optional.empty(); | ||
} | ||
|
||
@Override | ||
public URI filesUrl(Hash hash) { | ||
return null; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -161,4 +161,6 @@ public interface PullRequest extends Issue { | ||
* @return | ||
*/ | ||
void setTargetRef(String targetRef); | ||
|
||
URI filesUrl(Hash hash); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -257,4 +257,9 @@ public Diff diff() { | ||
throw new UncheckedIOException(e); | ||
} | ||
} | ||
|
||
@Override | ||
public URI filesUrl(Hash hash) { | ||
return URI.create(webUrl().toString() + "/files/" + hash.hex()); | ||
} | ||
} |
f16663b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues