build: use included build instead of buildSrc #1004
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
please review this small patch that makes the build use "included builds" for Skara's Gradle plugins instead of the "buildSrc" feature of Gradle. The "buildSrc" feature doesn't play nice with Gradle's caching mechanism - any change to a file in the
buildSrc
directory invalidates the build cache. The solution is to just include the plugins using theincludeBuild
feature (the Gradle team is even thinking of makingbuildSrc
an implicitly included build, see gradle/gradle#2531).Testing:
make images
on Linux x64make test
on Linux x64Thanks,
Erik
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/1004/head:pull/1004
$ git checkout pull/1004