Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use included build instead of buildSrc #1004

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Feb 10, 2021

Hi all,

please review this small patch that makes the build use "included builds" for Skara's Gradle plugins instead of the "buildSrc" feature of Gradle. The "buildSrc" feature doesn't play nice with Gradle's caching mechanism - any change to a file in the buildSrc directory invalidates the build cache. The solution is to just include the plugins using the includeBuild feature (the Gradle team is even thinking of making buildSrc an implicitly included build, see gradle/gradle#2531).


  • make images on Linux x64
  • make test on Linux x64



  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/1004/head:pull/1004
$ git checkout pull/1004

Copy link

@bridgekeeper bridgekeeper bot commented Feb 10, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 10, 2021
Copy link

@rwestberg rwestberg left a comment

Good stuff!

Copy link

@openjdk openjdk bot commented Feb 10, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

build: use included build instead of buildSrc

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 10, 2021
Copy link

@mlbridge mlbridge bot commented Feb 10, 2021


Copy link
Member Author

@edvbld edvbld commented Feb 10, 2021


@openjdk openjdk bot closed this Feb 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 10, 2021
Copy link

@openjdk openjdk bot commented Feb 10, 2021

@edvbld Pushed as commit de5c089.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants