Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

893: Skara has no mailing list rule for some macOS native client code #1006

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Feb 11, 2021

I'd like to add this rule


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-893: Skara has no mailing list rule for some macOS native client code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1006/head:pull/1006
$ git checkout pull/1006

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2021

Webrevs

@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 11, 2021

BTW I assume I have no project role so expect I'll need a sponsor ?

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

893: Skara has no mailing list rule for some macOS native client code

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 11, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 11, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@prrace
Your change (at version cc34d7f) is now ready to be sponsored by a Committer.

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 12, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@edvbld @prrace Since your change was applied there have been 3 commits pushed to the master branch:

  • 363871a: build: run build and tests in parallel
  • 6f833d3: build: update to Gradle 6.8.2
  • 406e4a9: Update BotSlackHandlerTest timeout

Your commit was automatically rebased without conflicts.

Pushed as commit ef5e027.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants