Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run build and tests in parallel #1009

Closed
wants to merge 3 commits into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 12, 2021

Hi all,

please review this patch that enables builds and tests to happen in parallel. I also tweaked the build a little:

  • the Gradle daemon now gets an Xmx of 2048 Mb
  • Gradle will run up to 100 tests in the same JVM before forking a new one
  • the JVM for compiling will be forked, reducing heap pressure on the Gradle daemon thread
  • enabled the file system watching feature for faster rebuilds

The results on my AMD Ryzen 5 3600 is that sh gradlew clean && sh gradlew --info test went from ~10 minutes to ~2 minutes 馃コ 馃殌

Testing:

  • make images on Linux x64
  • make test on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1009/head:pull/1009
$ git checkout pull/1009

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

馃憢 Welcome back ehelin! A progress list of the required criteria for merging this PR into pr/1008 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

鈿狅笍 @edvbld This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot changed the base branch from pr/1008 to master Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@edvbld This change now passes all automated pre-integration checks.

鈩癸笍 This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

馃攳 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

馃寧 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

build: run build and tests in parallel

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6f833d3: build: update to Gradle 6.8.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

鉃★笍 To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 12, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 12, 2021

/integrate

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated and removed ready labels Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

  • 6f833d3: build: update to Gradle 6.8.2

Your commit was automatically rebased without conflicts.

Pushed as commit 363871a.

馃挕 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants