Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid considering fixVersions that are not valid releases when calculating the hgupdate-sync label #1010

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 12, 2021

There may be backport records that have fixVersions that should be ignored when calculating which of them should receive the hgupdate-sync label.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1010/head:pull/1010
$ git checkout pull/1010

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

edvbld
edvbld approved these changes Feb 12, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Avoid considering fixVersions that are not valid releases when calculating the hgupdate-sync label

Reviewed-by: ehelin, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • ef5e027: 893: Skara has no mailing list rule for some macOS native client code
  • 363871a: build: run build and tests in parallel
  • 6f833d3: build: update to Gradle 6.8.2
  • 406e4a9: Update BotSlackHandlerTest timeout

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 12, 2021
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 15, 2021

/integrate

@openjdk openjdk bot closed this Feb 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2021

@rwestberg Since your change was applied there have been 4 commits pushed to the master branch:

  • ef5e027: 893: Skara has no mailing list rule for some macOS native client code
  • 363871a: build: run build and tests in parallel
  • 6f833d3: build: update to Gradle 6.8.2
  • 406e4a9: Update BotSlackHandlerTest timeout

Your commit was automatically rebased without conflicts.

Pushed as commit 5707318.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants