Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

574: git-info should use info from commit notifications #1011

Closed
wants to merge 6 commits into from

Conversation

@magicus
Copy link
Member

@magicus magicus commented Feb 12, 2021

git-info should use info from commit notifications to get the link to the review, not JBS (since not all PR have issues)

This required refactoring to move the hosted repo logic from cli/pr/Utils.java to where it can be accessed by all CLI tools. After some deliberating, I left a bunch of trivial wrappers in cli/pr/Utils.java -- otherwise this change would have touched all the files in cli/pr.

Testing: ad hoc testing of "git info" on some arbitrary Skara commits.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-574: git-info should use info from commit notifications

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1011/head:pull/1011
$ git checkout pull/1011

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

@magicus magicus marked this pull request as draft Feb 15, 2021
@openjdk openjdk bot removed the rfr label Feb 15, 2021
magicus added 2 commits Feb 15, 2021
* Fix crash in "git info" for projects where .jcheck/conf was missing the "jbs" key
@magicus magicus marked this pull request as ready for review Feb 15, 2021
edvbld
edvbld approved these changes Feb 16, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good modulo some whitespace issues found by jcheck 🤖

@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

574: git-info should use info from commit notifications

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@magicus
Copy link
Member Author

@magicus magicus commented Feb 16, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@magicus
Your change (at version e947d95) is now ready to be sponsored by a Committer.

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 17, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@edvbld @magicus Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit a8fe187.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the git-info-from-commit branch Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants