Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr: remove commitCommandUsers #1016

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 15, 2021

Hi all,

please review this patch that removes the commitCommandUsers functionality from the PR bot. There is no need to describe the users who should be allowed to issue commit commands, all users should be able to do so. Individual commit commands might choose to limit users (e.g. based on census), but that should be up to individual commit commands.

Testing:

  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1016/head:pull/1016
$ git checkout pull/1016

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 15, 2021
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 15, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

pr: remove commitCommandUsers

Reviewed-by: rwestberg, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 47b06d0: cli: add debug command commit-comments
  • 5707318: Avoid considering fixVersions that are not valid releases when calculating the hgupdate-sync label
  • ef5e027: 893: Skara has no mailing list rule for some macOS native client code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 15, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2021

Webrevs

@openjdk openjdk bot mentioned this pull request Feb 15, 2021
3 tasks
@edvbld
Copy link
Member Author

edvbld commented Feb 15, 2021

/integrate

@openjdk openjdk bot closed this Feb 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 15, 2021
@openjdk
Copy link

openjdk bot commented Feb 15, 2021

@edvbld Since your change was applied there have been 5 commits pushed to the master branch:

  • 3cf5bd0: pr: configure fork names explicitly
  • 56221f3: forge: double time-span for recent commit comments for GitLab
  • 47b06d0: cli: add debug command commit-comments
  • 5707318: Avoid considering fixVersions that are not valid releases when calculating the hgupdate-sync label
  • ef5e027: 893: Skara has no mailing list rule for some macOS native client code

Your commit was automatically rebased without conflicts.

Pushed as commit 8077766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants