Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of census upgrade bot #1019

Closed
wants to merge 4 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 16, 2021

Allows automated conversion of census.xml to the Skara format.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1019/head:pull/1019
$ git checkout pull/1019

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 16, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2021

Webrevs

Copy link
Member

@edvbld edvbld left a comment

Looks good, but may I suggest renaming CensusSyncDowngradeBot.java to CensusSyncUnifyBot.java and CensusSyncUpgradeBot.java to CensusSyncSplitBot.java? Makes it a bit more clear what the bots are doing 😃

xml/build.gradle Outdated

publishing {
publications {
webrev(MavenPublication) {
Copy link
Member

@edvbld edvbld Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
webrev(MavenPublication) {
xml(MavenPublication) {

edvbld
edvbld approved these changes Feb 17, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks great!

@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Initial version of census upgrade bot

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a8fe187: 574: git-info should use info from commit notifications
  • e267010: forge: improve GitLabRepository::commitWithComment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 17, 2021
@rwestberg
Copy link
Member Author

rwestberg commented Feb 17, 2021

/integrate

@openjdk openjdk bot closed this Feb 17, 2021
@openjdk openjdk bot added integrated and removed ready labels Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@rwestberg Since your change was applied there have been 2 commits pushed to the master branch:

  • a8fe187: 574: git-info should use info from commit notifications
  • e267010: forge: improve GitLabRepository::commitWithComment

Your commit was automatically rebased without conflicts.

Pushed as commit ab4c1f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Feb 17, 2021
authors.add(username);
break;
default:
if (name.equals("openjfx") && (username.equals("dwookey") || username.equals("jpereda"))) {
Copy link
Member

@magicus magicus Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is already integrated, but these sounds like weird hard-coded exceptions? If there are issues in the census data, maybe they should be fixed instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants