Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: improve GitLabRepository::commitWithComment #1020

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 16, 2021

Hi all,

please review this patch that improves the method GitLabRepository::commitWithComment. The problem is that GitLab's search API isn't really up to par (cannot handle square brackets in search query) and the search API is also going in away from GitLab CE in 13.9. This patch implements a simple search, just iterating backwards over the most recent commits, searching for the given title. The results are cached in-memory to speed up future searches.

Testing:

  • Manual testing on Linux x64 using git-skara debug commit-comments

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1020/head:pull/1020
$ git checkout pull/1020

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 16, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 16, 2021
@edvbld edvbld force-pushed the gitlab-commit-with-comment branch from 7acf8b4 to 4bc0eaf Compare Feb 16, 2021
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 16, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

forge: improve GitLabRepository::commitWithComment

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 16, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 16, 2021

/integrate

@openjdk openjdk bot closed this Feb 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@edvbld Pushed as commit e267010.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants