Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hgupdate-sync label functionality to SyncLabelBot #1021

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 17, 2021

Move the responsibility of updating the hgupdate-sync label to the SyncLabelBot.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1021/head:pull/1021
$ git checkout pull/1021

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2021

Webrevs

@@ -32,12 +32,12 @@

public class SyncLabelBotCheckWorkItem implements WorkItem {
Copy link
Member

@magicus magicus Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that it is not only checking, but also updating the labels, maybe rename the class?

Copy link
Member Author

@rwestberg rwestberg Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will change it.

edvbld
edvbld approved these changes Feb 19, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good modulo @magicus comment 👍

@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Move hgupdate-sync label functionality to SyncLabelBot

Reviewed-by: ehelin, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 3acaa00: cli: rework git-backport
  • c2e2ade: pr: add /clean command
  • ab4c1f1: Initial version of census upgrade bot
  • a8fe187: 574: git-info should use info from commit notifications

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 19, 2021
Copy link
Member

@magicus magicus left a comment

Looks good!

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 22, 2021

/integrate

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@rwestberg Since your change was applied there have been 5 commits pushed to the master branch:

  • 4857968: 572: Auto-correct PR title if it is a prefix of the JBS issue title
  • 3acaa00: cli: rework git-backport
  • c2e2ade: pr: add /clean command
  • ab4c1f1: Initial version of census upgrade bot
  • a8fe187: 574: git-info should use info from commit notifications

Your commit was automatically rebased without conflicts.

Pushed as commit db76f15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants