Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

572: Auto-correct PR title if it is a prefix of the JBS issue title #1023

Closed
wants to merge 3 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Feb 18, 2021

The PR bot should auto-correct PR titles if they are a known prefix of a JBS issue title instead of showing a warning that there is a mismatch between PR and JBS title.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-572: Auto-correct PR title if it is a prefix of the JBS issue title

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1023/head:pull/1023
$ git checkout pull/1023

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-572 572: Auto-correct PR title if it is a prefix of the JBS issue title Feb 18, 2021
@openjdk openjdk bot added the rfr label Feb 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2021

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

572: Auto-correct PR title if it is a prefix of the JBS issue title

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 3acaa00: cli: rework git-backport
  • c2e2ade: pr: add /clean command
  • ab4c1f1: Initial version of census upgrade bot
  • a8fe187: 574: git-info should use info from commit notifications

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 22, 2021
@magicus
Copy link
Member Author

@magicus magicus commented Feb 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@magicus
Your change (at version 7bf4816) is now ready to be sponsored by a Committer.

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 22, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@edvbld @magicus Since your change was applied there have been 4 commits pushed to the master branch:

  • 3acaa00: cli: rework git-backport
  • c2e2ade: pr: add /clean command
  • ab4c1f1: Initial version of census upgrade bot
  • a8fe187: 574: git-info should use info from commit notifications

Your commit was automatically rebased without conflicts.

Pushed as commit 4857968.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the fix-cutoff-pr-titles branch Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants