88: git token store https://github.com does not work

[kstefanj]

Hi,

Please review this fix to avoid getting exceptions when having URIs with empty paths. Instead of assuming a leading '/' we now check the path in GitCredentials.fill and only removes a leading '/' if it is present.

Basic tests pass, but the affected commands have not yet been tested thoroughly.

Thanks,
Stefan

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Jorn Vernee (jvernee - Committer)
• Erik Helin (ehelin - Reviewer)

[bridgekeeper]

👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 00: Full (8903663)

[JornVernee]

@kstefanj thanks for fixing this! Change looks good.

[edvbld]

Looks good, thanks for fixing!

[openjdk]

@kstefanj This change can now be integrated. The commit message will be:

88: git token store https://github.com does not work

Reviewed-by: jvernee, ehelin

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

• 910b2c8: Add merge bot
• 660d626: Add Repository::abortMerge
• f4de221: Add optional handler for workitem runtime errors
• 482ee91: TestHostedRepository::getPullRequests should only return open PRs

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @edvbld) but any other Committer may sponsor as well.

• To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kstefanj]

/integrate

[openjdk]

@kstefanj
Your change (at version 8903663) is now ready to be sponsored by a Committer.

[JornVernee]

/sponsor

[openjdk]

@JornVernee @kstefanj The following commits have been pushed to master since your change was applied:

• 910b2c8
• 660d626
• f4de221
• 482ee91

Your commit was automatically rebased without conflicts.
Pushed as commit 59c6145.