New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
88: git token store https://github.com does not work #103
Conversation
|
@kstefanj This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 4 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @edvbld) but any other Committer may sponsor as well.
|
/integrate |
/sponsor |
Hi,
Please review this fix to avoid getting exceptions when having URIs with empty paths. Instead of assuming a leading '/' we now check the path in GitCredentials.fill and only removes a leading '/' if it is present.
Basic tests pass, but the affected commands have not yet been tested thoroughly.
Thanks,
Stefan
Progress
Approvers