Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

88: git token store https://github.com does not work #103

Closed
wants to merge 1 commit into from

Conversation

@kstefanj
Copy link

kstefanj commented Aug 29, 2019

Hi,

Please review this fix to avoid getting exceptions when having URIs with empty paths. Instead of assuming a leading '/' we now check the path in GitCredentials.fill and only removes a leading '/' if it is present.

Basic tests pass, but the affected commands have not yet been tested thoroughly.

Thanks,
Stefan

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Jorn Vernee (jvernee - Committer)
  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2019

👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added cli rfr labels Aug 29, 2019
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2019

Webrevs

Copy link
Member

JornVernee left a comment

@kstefanj thanks for fixing this! Change looks good.

@edvbld
edvbld approved these changes Aug 29, 2019
Copy link
Member

edvbld left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Aug 29, 2019
@openjdk
Copy link

openjdk bot commented Aug 29, 2019

@kstefanj This change can now be integrated. The commit message will be:

88: git token store https://github.com does not work

Reviewed-by: jvernee, ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 910b2c8: Add merge bot
  • 660d626: Add Repository::abortMerge
  • f4de221: Add optional handler for workitem runtime errors
  • 482ee91: TestHostedRepository::getPullRequests should only return open PRs

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @edvbld) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@openjdk openjdk bot added the ready label Aug 29, 2019
@kstefanj
Copy link
Author

kstefanj commented Aug 29, 2019

/integrate

@openjdk openjdk bot added the sponsor label Aug 29, 2019
@openjdk
Copy link

openjdk bot commented Aug 29, 2019

@kstefanj
Your change (at version 8903663) is now ready to be sponsored by a Committer.

@JornVernee
Copy link
Member

JornVernee commented Aug 29, 2019

/sponsor

@openjdk openjdk bot closed this Aug 29, 2019
@openjdk openjdk bot added the integrated label Aug 29, 2019
@openjdk
Copy link

openjdk bot commented Aug 29, 2019

@JornVernee @kstefanj The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 59c6145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.