Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional sync label tests, adjust the implementation to match #1033

wants to merge 1 commit into from


Copy link

@rwestberg rwestberg commented Feb 24, 2021

Adjust the implementation of the sync label rules to match expectations.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/1033/head:pull/1033
$ git checkout pull/1033

Copy link

@bridgekeeper bridgekeeper bot commented Feb 24, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 24, 2021
Copy link

@mlbridge mlbridge bot commented Feb 24, 2021


edvbld approved these changes Feb 24, 2021
Copy link

@edvbld edvbld left a comment

Looks good!

Copy link

@edvbld edvbld commented Feb 24, 2021

@rwestberg you might want to fix the test failure though 😉

Copy link

@openjdk openjdk bot commented Feb 24, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

Add additional sync label tests, adjust the implementation to match

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 874a89c: pr: fetch commit comments in work item
  • 7e9643c: Avoid expensive operations when comparing commit command work items
  • a814a3d: pr: handle exceptions when fetching commit comments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 24, 2021
@rwestberg rwestberg closed this Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants