Read resolvedInBuild JBS property properly #1042
Conversation
|
|
| if (issue.properties().containsKey("customfield_10006")) { | ||
| return JdkVersion.parse(versionString.get(0), issue.properties().get("customfield_10006").asString()); |
There was a problem hiding this comment.
Would you mind creating a variable naming the custom field? For example:
var resolvedInBuild = "customfield_10006";
if (issue.properties().containsKey(resolvedInBuild)) {There was a problem hiding this comment.
This exist in quite a few places already, and properly fixing it would require a larger refactoring. So I think we should do that separately.
|
@rwestberg This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
|
/integrate |
|
@rwestberg Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2c63ced. |
The resolvedInBuild property was not read correctly from JBS, leading to incorrect issue labels.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/1042/head:pull/1042$ git checkout pull/1042