New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Download message in PR description #1053
Conversation
|
You mean when you are updating your local copy of someone else's pull request? Because otherwise you just pull from your personal fork, right? |
If you follow the instructions in the Download section to get a local copy of the PR, this works just fine. However, if you want to update your local copy when the PR has changed with new code, this turned out to be a non-trivial exercise in gitology for both me and Volker (and many more, I presume). I think this is understood from the context of the "Download" part. |
Ok, I see what you want to do. My below instructions are not appropriate to add to the pull request body (due to the complexity of the commands), but the most ergonomic way to set this up is to just add a remote and add an additional fetch command:
Then whenever you want to checkout a pull request locally you can just run
The above will ensure that the local branch |
@magicus This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@magicus Since your change was applied there have been 9 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a6a7efa. |
@simonis yep, that is correct. As usual when you fetch refs from a remote they will only becomes refs under |
@edvbld thanks for the confirmation. I'll definitely put that line into my |
Both @simonis and I have struggled of finding the proper way to update a checked-out PR. Let's update the help text with Volker's findings of the best way to do this!
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/1053/head:pull/1053
$ git checkout pull/1053