vcs: add ReadOnlyRepository.commitMetadataFor

[edvbld]

Hi all,

please review this patch that adds the method ReadOnlyRepository.commitMetadataFor. I opted to not implement the Mercurial version due to the way HgRepository tries to mimic Git branches using bookmarks. The Skara code that uses HgRepository has never needed to use branches, so the the current bookmark implementation is more of a proof-of-concept. The implementation of the ReadOnlyRepository.commitMetadataFor for HgRepository would look something like the following:

@Override
public List<CommitMetadata> commitMetadataFor(List<Branch> branches) throws IOException {
    var cmd = new ArrayList<String>();
    cmd.addAll(List.of("hg", "log", "--template", HgCommitMetadata.TEMPLATE));
    for (var branch : branches) {
        cmd.add("--rev");
        cmd.add("0:" + branch.name());
    }
    return readMetadata(cmd);
}

The above will get messy however if branches contains a proper branch (e.g. default) and not just a bookmark. This can be solved, but I don't think it is worth it right now. If we ever need to write a tool interacting with Mercurial repositories that needs commitMetadataFor then we can implement the method then.

Please also note that I had to name the method commitMetadataFor instead of just overloading commitMetadata since we already have commitMetadata(List<Path>).

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Reviewers

• Robin Westberg (@rwestberg - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/1058/head:pull/1058
$ git checkout pull/1058

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (91fc5cc)

[rwestberg]

Sounds reasonable!

[openjdk]

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

vcs: add ReadOnlyRepository.commitMetadataFor

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• b39d50b: Add missing copyright headers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

• b39d50b: Add missing copyright headers

Your commit was automatically rebased without conflicts.

Pushed as commit 902698a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.