Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running PullRequestBot WorkItems for the same PR concurrently #106

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 29, 2019

Hi all,

Please review this change that ensures that the WorkItems used by the PullRequestBot are not run concurrently for the same PR. This avoids a race condition where two tasks try to update the sponsor label at the same time.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 29, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 29, 2019

Webrevs

edvbld
edvbld approved these changes Aug 29, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 29, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2019

@rwestberg This change can now be integrated. The commit message will be:

Avoid running PullRequestBot WorkItems for the same PR concurrently

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 29, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 29, 2019

/integrate

@openjdk openjdk bot closed this Aug 29, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2019

@rwestberg Pushed as commit 417c6f5.

@openjdk openjdk bot added the integrated label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants