vcs: make RepositoryTests deterministic

[edvbld]

Hi all,

please review this small patch to make the test RepositoryTests.testCommitMetadataWithBranchesWithGit deterministic. The problem is that different versions of git can traverse the commit graph differently and the resulting list from the call to commitMetadataFor might therefore contain commits in an unknown order. The test should therefore not assume that the commits are ordered in a particular way, but instead ensure that the list contains only the expected commits.

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Reviewers

• Robin Westberg (@rwestberg - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/1061/head:pull/1061
$ git checkout pull/1061

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[rwestberg]

Looks good!

[openjdk]

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

vcs: make RepositoryTests deterministic

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (ae54233)

[edvbld]

/integrate

[openjdk]

@edvbld Pushed as commit 79e2056.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.