Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

627: Review comments are in different order in different e-mails #1067

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 17, 2021

Sort review comments by filename and line to make the resulting emails more consistent.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-627: Review comments are in different order in different e-mails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1067/head:pull/1067
$ git checkout pull/1067

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 627 627: Review comments are in different order in different e-mails Mar 17, 2021
@openjdk openjdk bot added the rfr label Mar 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2021

Webrevs

edvbld
edvbld approved these changes Mar 17, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

627: Review comments are in different order in different e-mails

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 7e3e460: 890: jdk.json mapping modules and some files to the wrong area
  • 2e05c53: Ensure the ssh configuration folder exists
  • 6f95f73: pr: align help text for commit commands
  • a6a7efa: Improve the Download message in PR description
  • dc052db: pr: use bare repo for CommitCommentsWorkItem
  • 2ca0412: Add support for using ssh cloning with GitLab
  • 79e2056: vcs: make RepositoryTests deterministic
  • 763af0c: bot: don't run watchdogTrigger test on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 17, 2021
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 17, 2021

/integrate

@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@rwestberg Since your change was applied there have been 8 commits pushed to the master branch:

  • 7e3e460: 890: jdk.json mapping modules and some files to the wrong area
  • 2e05c53: Ensure the ssh configuration folder exists
  • 6f95f73: pr: align help text for commit commands
  • a6a7efa: Improve the Download message in PR description
  • dc052db: pr: use bare repo for CommitCommentsWorkItem
  • 2ca0412: Add support for using ssh cloning with GitLab
  • 79e2056: vcs: make RepositoryTests deterministic
  • 763af0c: bot: don't run watchdogTrigger test on Windows

Your commit was automatically rebased without conflicts.

Pushed as commit 41e5dff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants