Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct a proper SSH URI #1068

wants to merge 1 commit into from


Copy link

@rwestberg rwestberg commented Mar 17, 2021

When using SSH with GitLab, create a proper SSH URI to avoid unnecessary string manipulation later.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/1068/head:pull/1068
$ git checkout pull/1068

Copy link

bridgekeeper bot commented Mar 17, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2021
Copy link

mlbridge bot commented Mar 17, 2021


edvbld approved these changes Mar 17, 2021
Copy link

@edvbld edvbld left a comment

Looks good!

Copy link

openjdk bot commented Mar 17, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

Construct a proper SSH URI

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 17, 2021
Copy link
Member Author

rwestberg commented Mar 17, 2021


@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 17, 2021
Copy link

openjdk bot commented Mar 17, 2021

@rwestberg Since your change was applied there has been 1 commit pushed to the master branch:

  • 41e5dff: 627: Review comments are in different order in different e-mails

Your commit was automatically rebased without conflicts.

Pushed as commit 16ca4cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants