Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jcheck "repository" property in [general] section not read from .jcheck/conf #107

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 29, 2019

This PR fixes a typo in the GeneralConfiguration class of jcheck that causes the repository property to be set to the same value as project rather than being read from the .jcheck/conf file.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 29, 2019

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 29, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 29, 2019

Webrevs

edvbld
edvbld approved these changes Aug 29, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Aug 29, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2019

@kevinrushforth This change can now be integrated. The commit message will be:

jcheck "repository" property in [general] section not read from .jcheck/conf

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 29, 2019
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 29, 2019

/integrate

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 29, 2019

I might have expected the /integrate in the previous comment to cause the bot to wake up and annotate the PR to indicate that it was now ready to be sponsored. Does it not do that? Should it?

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 30, 2019

It most certainly should wake up, I've filed https://bugs.openjdk.java.net/browse/SKARA-91 to track the fix.

@openjdk openjdk bot added the sponsor label Aug 30, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2019

@kevinrushforth
Your change (at version c3a15a1) is now ready to be sponsored by a Committer.

@edvbld
Copy link
Member

@edvbld edvbld commented Aug 30, 2019

/sponsor

@openjdk openjdk bot closed this Aug 30, 2019
@openjdk openjdk bot added the integrated label Aug 30, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2019

@edvbld @kevinrushforth Pushed as commit b46b8e5.

@kevinrushforth kevinrushforth deleted the fix-general-repository-prop branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants