New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr: add /integrate auto #1071
pr: add /integrate auto #1071
Conversation
👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@edvbld This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. 🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it. 🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@edvbld Since your change was applied there have been 6 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 77cbb92. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
please review this patch that adds the
auto
andmanual
arguments to the/integrate
pull request command. If a contributor issues/integrate auto
then the pull request will be automatically integrated when the pull request is ready (i.e. when jcheck passes). To aid reviewers that this is the case the label "auto" will be added to such pull requests. A contributor can always go back to "manual" mode by issuing the/integrate auto
.This functionality is useful for smaller patches where you are certain that they are correct, for example fixing a typo in a comment. It it also useful for clean backports since most projects consider clean backports ready to be integrated without a review. This allows a backporter to add
/integrate auto
to the bottom of the PR body for a clean backport and then it will automatically be integrated if it is considered clean.I also added a bunch of unit tests.
Thanks,
Erik
Progress
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1071/head:pull/1071
$ git checkout pull/1071
To update a local copy of the PR:
$ git checkout pull/1071
$ git pull https://git.openjdk.java.net/skara pull/1071/head