323: ArgumentParser should support --version

[edvbld]

Hi all,

please review this patch that makes the CLI tools not show an error when required flags and inputs are missing and the flag --version is specified. If a user runs git <tool> --version then they shouldn't have to add required flags or input, they just want to see the version.

Testing:

• Manual testing on Linux x64

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-323: ArgumentParser should support --version

Reviewers

• Robin Westberg (@rwestberg - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1078/head:pull/1078
$ git checkout pull/1078

To update a local copy of the PR:
$ git checkout pull/1078
$ git pull https://git.openjdk.java.net/skara pull/1078/head

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (a09a8a6)

[rwestberg]

Looks good!

[openjdk]

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

323: ArgumentParser should support --version

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• cd84028: cli: make it possible to configure forge name
• f16663b: 744: The "Webrevs" link in the PR has confusing link to the changes for just one commit
• 60eb3a6: cli: add --atomic and --manual to git-pr-integrate
• e6502c8: 757: git webrev with file list fails if any file has not changed
• fedf7ad: 823: git fork --setup-pre-push-hook => FAIL

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld Since your change was applied there have been 5 commits pushed to the master branch:

• cd84028: cli: make it possible to configure forge name
• f16663b: 744: The "Webrevs" link in the PR has confusing link to the changes for just one commit
• 60eb3a6: cli: add --atomic and --manual to git-pr-integrate
• e6502c8: 757: git webrev with file list fails if any file has not changed
• fedf7ad: 823: git fork --setup-pre-push-hook => FAIL

Your commit was automatically rebased without conflicts.

Pushed as commit d4d23aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.