Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying to update build number for tags that don't have one #1082

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 19, 2021

The issue notifier can be configured to update the build number of issues when a corresponding tag is created. However, certain tags don't contain build number information, so don't attempt this for those.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1082/head:pull/1082
$ git checkout pull/1082

To update a local copy of the PR:
$ git checkout pull/1082
$ git pull https://git.openjdk.java.net/skara pull/1082/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 19, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 19, 2021

Webrevs

@edvbld
Copy link
Member

@edvbld edvbld commented Mar 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@edvbld Only the author (@rwestberg) is allowed to issue the integrate command.

edvbld
edvbld approved these changes Mar 22, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Avoid trying to update build number for tags that don't have one

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 758928b: Remove java.lang.invoke from hotspot-compiler
  • 1c2c6f3: Add -t/--tool to pr show to use git difftool
  • 77107ba: pr: use LinkedHashSet for CommitCommentsWorkItem
  • affbc38: Turn an exception into a log message to allow further issues to be processed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 22, 2021
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 22, 2021

/integrate

@openjdk openjdk bot closed this Mar 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@rwestberg Since your change was applied there have been 5 commits pushed to the master branch:

  • 1843566: pr: enable exclusion of commit comments authors
  • 758928b: Remove java.lang.invoke from hotspot-compiler
  • 1c2c6f3: Add -t/--tool to pr show to use git difftool
  • 77107ba: pr: use LinkedHashSet for CommitCommentsWorkItem
  • affbc38: Turn an exception into a log message to allow further issues to be processed

Your commit was automatically rebased without conflicts.

Pushed as commit 3fb77c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants