Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to JUnit 5.7.1 #1087

Closed
wants to merge 2 commits into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 22, 2021

Hi all,

please review this patch that updates JUnit to version 5.7.1 (and JUnit Platform to 1.7.1).

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1087/head:pull/1087
$ git checkout pull/1087

Update a local copy of the PR:
$ git checkout pull/1087
$ git pull https://git.openjdk.java.net/skara pull/1087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1087

View PR using the GUI difftool:
$ git pr show -t 1087

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1087.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into pr/1086 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 22, 2021
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@mlbridge
Copy link

mlbridge bot commented Mar 22, 2021

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1086 to master Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

build: update to JUnit 5.7.1

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@edvbld
Copy link
Member Author

edvbld commented Apr 12, 2021

/integrate

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 12, 2021
@openjdk
Copy link

openjdk bot commented Apr 12, 2021

@edvbld Since your change was applied there have been 32 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit cd6a10f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants