Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch commit, add and files methods in HgRepository #109

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Aug 30, 2019

Hi all,

this small patch adds "batching" to the commit, add and files methods in HgRepository to avoid command-line overflow for large lists.

Testing

  • sh gradlew test passes on Linux x86_64

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 30, 2019
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Wondering if the allFiles could use the batch function as well with some refactoring, but no need to change that now.

@openjdk openjdk bot removed the rfr label Aug 30, 2019
@openjdk
Copy link

openjdk bot commented Aug 30, 2019

@edvbld This change can now be integrated. The commit message will be:

Batch commit, add and files methods in HgRepository

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • c999004: Batch commit, add and files methods in HgRepository
  • 1f95176: 91: Avoid discarding pending items of different types
  • b46b8e5: jcheck "repository" property in [general] section not read from .jcheck/conf

Your changes cannot be rebased automatically without conflicts, so you will need to merge master into your branch before integrating.

@openjdk openjdk bot added the ready label Aug 30, 2019
@edvbld
Copy link
Member Author

edvbld commented Aug 30, 2019

/integrate

@openjdk openjdk bot closed this Aug 30, 2019
@openjdk openjdk bot added the integrated label Aug 30, 2019
@openjdk
Copy link

openjdk bot commented Aug 30, 2019

@edvbld The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit c999004.

@openjdk openjdk bot added the outdated label Aug 30, 2019
@edvbld edvbld deleted the edvbld:hg-batch branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.