Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

659: Multi-line commands aren't filtered properly #1092

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 24, 2021

After a command has been found, filter out the rest of the body.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-659: Multi-line commands aren't filtered properly

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1092/head:pull/1092
$ git checkout pull/1092

To update a local copy of the PR:
$ git checkout pull/1092
$ git pull https://git.openjdk.java.net/skara pull/1092/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 24, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 659 659: Multi-line commands aren't filtered properly Mar 24, 2021
@openjdk openjdk bot added the rfr label Mar 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

659: Multi-line commands aren't filtered properly

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e7099c9: Make "git debug mlrules" tolerate missing files, and clarify help

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 25, 2021
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 30, 2021

/integrate

@openjdk openjdk bot closed this Mar 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2021

@rwestberg Since your change was applied there have been 7 commits pushed to the master branch:

  • c33a832: 940: Exception during item execution: has integrated label but no integration comment
  • 2234a03: 939: Improve robustness and error reporting on invalid fixVersion
  • 3a40804: mlbridge: use nicer link for webrev commits
  • 51c3659: pr: fix configuration of forks
  • fb56e23: Reviewing help markdown does not work on gitlab
  • f7748c0: Improve the help for reviewers
  • e7099c9: Make "git debug mlrules" tolerate missing files, and clarify help

Your commit was automatically rebased without conflicts.

Pushed as commit 99e01cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants